handle CIRCUITPY_SAFE_MODE_DELAY in settings.toml - #11073
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8709, in a somewhat different way.
Add
CIRCUITPY_SAFE_MODE_DELAYtosettings.toml. If specified, it allows the user to change the length of the safe mode delay, during which a second press of the reset button goes into safe mode. The value is specifed as a float number of seconds. If the delay is 0, it effectively turns off the feature.This required moving the safe-mode wait until after CIRCUITPY is mounted, so
settings.tomlcan be read. I think this is OK, but if you think of a problem, let me know.