Pmwout resource error messages - #11107
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error messages produced by
PWMOutconstruction are confusing when there is conflict with a previously createdPWMOut: sometimes the frequency is invalid, sometimes you get a resource message. Simplify the error codes and add a new error messageConflicting settings for shared resourcewhich is clearer.I looked at other non-
PWMOutuses of the original shared message ``Internalresource(s) in useand didn't find any that would benefit from switching the messageWhile doing
make translateI got a message that--sort-output(-s) is deprecated forxgettextandmergemsg. I think the original idea was that it minimizes the merge changes when a messages are changed, add, or removed. There is some good reason for the deprecation but I couldn't find a good explanation. It appears--sort-by-fileis fine for similarly canonicalizing the output, but it will cause a big diff this one time.