Skip to content

Suggestion for Code Refactoring and Enhancement in Anime Tracker python project #3080

Description

@Nancy248

I have reviewed the current implementation of the code in the repository, specifically in the [anime_tracker.py] file. I noticed some opportunities for improvement and would like to suggest the following modifications
Proposed Changes:

Modularization: The code can benefit from improved modularization. I've introduced separate functions to handle different responsibilities, making the code more readable and maintainable.

Exception Handling: by adding proper exception handling for potential errors during HTTP requests and HTML parsing, ensuring a more robust user experience.

Global Variable Elimination: The use of a global variable (soup) has been eliminated. Instead, the BeautifulSoup object is now passed between functions as a return value.

User Input Processing: User input processing has been moved to a separate function (main) for better organization, and a Keyboard Interrupt check has been added to handle program termination by the user.

Tag Presentation: Tags are now presented as a list, improving readability.

I would be happy to discuss these changes. Thank you
and let me know if it suits good

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

assignedIssues which are assigned to someoneenhancementNew feature or requestgood first issueGood for newcomers

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions