Skip to content

Add compact import generation in wasm-smith - #2627

Merged
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
chacailline:compact-imports
Aug 27, 2026
Merged

alexcrichton merged 2 commits into
bytecodealliance:mainfrom
chacailline:compact-imports

Conversation

@chacailline

@chacailline chacailline commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Updates wasm-smith to generate compact import sections.

Allows wasmtime fuzzing of compact import sections for bytecodealliance/wasmtime#14108.

Module::imports_exports_from_module_shape and Module::arbitrary_imports_from_available are also updated to accept compact imports and to generate them when it's enabled in the config.

I enabled the proposal by default. config.rs has a comment saying "Proposals that are not stage4+ are disabled by default." By that logic, we may want to enable wide arithmetic by default too.

Outside of #[cfg(feature = "component-model")], DuplicateImportsBehavior::Disallowed was only ever created in an if-test in Module::arbitrary_imports, so I had to add a #[cfg] gate to pass CI.

The binary format supports empty compact import statements, but it's not clear whether the text format will support them. See WebAssembly/compact-import-section#22. Currently, wasmparser doesn't accept them, but wasmprinter outputs them if given a binary with empty statements.

For now, I don't generate empty statements. If they're not allowed, we should update wasmprinter not to generate them. If they are allowed, we should update wasmparser to accept them, and probably generate them in wasm-smith.

@chacailline
chacailline requested a review from a team as a code owner August 27, 2026 03:27
@chacailline
chacailline requested review from alexcrichton and removed request for a team August 27, 2026 03:27
@chacailline

Copy link
Copy Markdown
Contributor Author

Module::arbitrary_imports gained some complexity because we have to check constraints in the nested loops too. We also can't use arbitrary_loop for the outer loop. We could for the inner loops, but I didn't think it would be any cleaner.

Module::arbitrary_imports_from_available instead generates all imports to start, then decides whether to group adjacent ones with the same module / type. This is cleaner, but if we did it with random module / type names, I think we would almost never generate any compact imports with more than 1 element.

@alexcrichton alexcrichton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me, thanks! It's expected that this'd generally make things more complicated but everything here looks as I'd expect

@alexcrichton
alexcrichton added this pull request to the merge queue Aug 27, 2026
Merged via the queue into bytecodealliance:main with commit e13a9ab Aug 27, 2026
37 checks passed
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
wasm-tools 1.259.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Refactor name resolution of components in the text format by @alexcrichton in bytecodealliance/wasm-tools#2621
* Import component spec tests as a submodule and run them. by @alexcrichton in bytecodealliance/wasm-tools#2623
* Fix name uniqueness with methods/interfaces by @alexcrichton in bytecodealliance/wasm-tools#2625
* Add compact import generation in wasm-smith by @chacailline in bytecodealliance/wasm-tools#2627
* Drop hyphens when testing equality of kebab names by @alexcrichton in bytecodealliance/wasm-tools#2626
* Enable wide-arithmetic by default in wasm-smith by @alexcrichton in bytecodealliance/wasm-tools#2628
* Validate the size of defined component types by @alexcrichton in bytecodealliance/wasm-tools#2624
* Update Wasmtime used in testing/fuzzing by @alexcrichton in bytecodealliance/wasm-tools#2629
* Fix text format outer aliases from recent refactor by @alexcrichton in bytecodealliance/wasm-tools#2631
* Remove `cancellable` immediate from component model intrinsics by @alexcrichton in bytecodealliance/wasm-tools#2630
* Start requiring "strict" indices in the text format by @alexcrichton in bytecodealliance/wasm-tools#2633
* Enable the `cm-implements` and `cm-map` features by default by @alexcrichton in bytecodealliance/wasm-tools#2634
* Clamp sizes of element segments in wasm-smith by @alexcrichton in bytecodealliance/wasm-tools#2632
* Fix wit-smith generating huge types by @alexcrichton in bytecodealliance/wasm-tools#2636
* Fix disallow_traps in wasm-smith with custom page sizes by @alexcrichton in bytecodealliance/wasm-tools#2635
* Resolve Cargo warnings on nightly by @alexcrichton in bytecodealliance/wasm-tools#2642
* Return an error instead of panicking on fixed-length-list size overflow by @zikk090 in bytecodealliance/wasm-tools#2643
* Try to improve performance of `deinline_import_export` by @alexcrichton in bytecodealliance/wasm-tools#2647
* Document a non-obvious method argument by @alexcrichton in bytecodealliance/wasm-tools#2645
* wasm-wave: Clean up syntax docs by @lann in bytecodealliance/wasm-tools#2644
* Update dependency major tracks by @alexcrichton in bytecodealliance/wasm-tools#2649
* Release wasm-tools 1.259.0 by @github-actions[bot] in bytecodealliance/wasm-tools#2650

## New Contributors
* @chacailline made their first contribution in bytecodealliance/wasm-tools#2627
* @zikk090 made their first contribution in bytecodealliance/wasm-tools#2643

**Full Changelog**: https://github.com/bytecodealliance/wasm-tools/compare/v1.258.0...v1.259.0</pre>
  <p>View the full release notes at <a href="https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.259.0">https://github.com/bytecodealliance/wasm-tools/releases/tag/v1.259.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!20061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants