Fix allocating type ids beyond wasmparser's implementation limit - #2687
Merged
Merged
Conversation
The design of `PackedIndex` and `RefType` and such is intended to ensure that any one single core module can validate correctly but this does not work when a component might contain multiple core modules. In such a situation wasmparser would previously panic when creating `RefType`s from internally-allocated IDs because the ID didn't fit within a `PackedIndex`. The fix applied here is to have rec-group registration be fallible and test the implementation limits before committing to insert a rec group.
alexcrichton
requested review from
fitzgen and
pchickey
and removed request for
a team and
pchickey
September 28, 2026 19:49
fitzgen
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design of
PackedIndexandRefTypeand such is intended to ensure that any one single core module can validate correctly but this does not work when a component might contain multiple core modules. In such a situation wasmparser would previously panic when creatingRefTypes from internally-allocated IDs because the ID didn't fit within aPackedIndex. The fix applied here is to have rec-group registration be fallible and test the implementation limits before committing to insert a rec group.