Limit total components/modules in validation - #2730
Merged
alexcrichton merged 1 commit intoOct 2, 2026
Merged
alexcrichton merged 1 commit into
alexcrichton merged 1 commit into
Conversation
This commit places a total limit on the number of nested components/modules within an entire outer component. Previously wasmparser would limit components/modules within one component, but the goal of this limit is to ensure that the entire total cap is limited. The original motivation for this is that wasmparser currently has some quadratic handling of type information when components/modules end, so components with lots of constituents can take an inordinately long amount of time to validate. Placing a limit is a bit of a quick fix for that and if we want to increase the limit we'll want to work on better data structures internally.
dicej
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit places a total limit on the number of nested components/modules within an entire outer component. Previously wasmparser would limit components/modules within one component, but the goal of this limit is to ensure that the entire total cap is limited. The original motivation for this is that wasmparser currently has some quadratic handling of type information when components/modules end, so components with lots of constituents can take an inordinately long amount of time to validate. Placing a limit is a bit of a quick fix for that and if we want to increase the limit we'll want to work on better data structures internally.