Use block height for id on contract import - #209
Merged
Merged
Conversation
JonoPrest
reviewed
Sep 17, 2024
| true => format!("${{{event_var_name}.transaction.id}}"), | ||
| false => format!("${{{event_var_name}.block.number}}"), | ||
| let block_number_field = match is_fuel { | ||
| true => "heigth", |
Collaborator
There was a problem hiding this comment.
I think height is spelled wrong here.
JonoPrest
requested changes
Sep 17, 2024
JonoPrest
left a comment
JonoPrest
left a comment
Collaborator
There was a problem hiding this comment.
Could you double check that it works? I think there is a typo.
Member
Author
|
Fixed and tested 🙏 |
JonoPrest
requested changes
Sep 17, 2024
JonoPrest
left a comment
JonoPrest
left a comment
Collaborator
There was a problem hiding this comment.
Sorry looks like another one...
Co-authored-by: Jono Prest <65739024+JonoPrest@users.noreply.github.com>
Member
Author
|
I'm surprised by my ability making silly mistakes when I'm lazy to test something because I'm 100% sure that it works |
JonoPrest
approved these changes
Sep 17, 2024
JonoPrest
left a comment
JonoPrest
left a comment
Collaborator
There was a problem hiding this comment.
Ok cool, looks great 👌🏼
Collaborator
No problem at all 🙏🏼 that's why we have reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.