ci: run the Windows pytest step with --capture=sys (refs #10) - #25
Merged
Merged
Conversation
…its console handles (#10) The Java dump caught the Windows hang: the main thread blocked in FileOutputStream.writeBytes under a LSMVectorIndex.build progress log. pytest's fd capture swaps fds 1 and 2 around each test, which on Windows closes the handle the JVM cached for System.out/err; a later pipe can be handed the same value. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWcDr7TwvcfMsQkeYQVHZr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #10 (kept open until the Windows jobs have run clean for a while; a single green run proves nothing for an intermittent hang).
What changed
test-python-bindings.yml: the pytest step adds--capture=syswhenRUNNER_OSis Windows, with a comment giving the mechanism.docs/development/ci-setup.mdanddocs/development/testing/overview.md: the same, and the advice to run with--capture=syson Windows locally.Why
The Java dump from #11 fired on run 36625374176: the Java main thread was blocked in
FileOutputStream.writeBytesunderLSMVectorIndex.build's progress log, while the Python side printed the dump to the real stdout without trouble. pytest's default fd capture swaps fds 1 and 2 around each test; on Windows that closes the handle the JVM cached forSystem.out/System.err, and a later pipe can be handed the same handle value, so the next Java log line blocks once that pipe is full. The diagnosis is on #10. With--capture=syspytest never touches the fds. No test usescapfd.How it was verified
pre-commitandactionlinton the changed files.🤖 Generated with Claude Code
https://claude.ai/code/session_01WWcDr7TwvcfMsQkeYQVHZr