fix(ui): preserve tree drag and scroll across spaces - #938
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Virtual tree dragging could lose its source before the drop handler ran, and HTTP data refreshes could scroll back to the selected entry. Keep the drag source mounted until dragend and reveal the active row only on navigation or initial mounting, after its data and expanded ancestors are available.
Enable the same virtual tree behavior for Code and Notes folders. Replace DOM-only folder scrolling with shared active-row reveal and connect new-folder rename requests to the virtual tree editor. Preserve selection and scroll across renames, moves and background refreshes.
This PR contains only tree changes on top of the optimizations already merged into main.
Validation