fix(search): reset vault-specific search state - #940
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching vaults during a snippet search retained the query and pre-search selection. Clearing the query could restore a snippet or folder from the previous vault. Reset snippet search state when the Code space is reset, and also discard the HTTP pre-search selection snapshot during its existing search reset.
Audited the remaining search entry points: Notes was fixed in #939; Math, Drawings, editor content search, and local HTTP filters are component-local and unmount when navigating to vault settings; the command palette clears its search on close.
Validation: 35 targeted tests passed across snippet search, Code initialization, HTTP search/initialization, and Notes search/initialization. Scoped ESLint passed. Added regressions covering vault changes and subsequent search restoration. No manual application UI verification.