String support chakracore - #979
Merged
Connor Peet (connor4312) merged 3 commits intoApr 23, 2021
Merged
Conversation
| }); | ||
|
|
||
| itIntegrates('chakracore string value', async ({ r }) => { | ||
| createFileTree(testFixturesDir, { |
There was a problem hiding this comment.
You'll want to bail out here if process.platform !== 'win32'
Contributor
Author
There was a problem hiding this comment.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some types of Office Add-ins use ChakraCore to run their java script which seem to have a problem with vscode evaluating strings from variables in the code. This stems for the fact that the vscode-js-debug plugin is based on V8 which uses a "value" property in the object returned in their protocol where ChakraCore uses "description". This change allows for either property to be used with "value" taking precedent over "description". The allows us to use vscode for this type of office add-in development.
Note the change also includes a test case for this using ChakraCore assemblies.