Skip to content

Implement selection paste for integrated terminal on Linux - #108397

Merged
Daniel Imms (Tyriar) merged 10 commits into
microsoft:mainfrom
awilkins:feature/selection-paste-in-terminal
Mar 30, 2021
Merged

Daniel Imms (Tyriar) merged 10 commits into
microsoft:mainfrom
awilkins:feature/selection-paste-in-terminal

Conversation

@awilkins

Copy link
Copy Markdown

This PR fixes #108380 by adding behaviour and keybinding consistent with
typical Linux terminal behaviour in the internal terminal.

  • Adds an action
    • workbench.action.terminal.pasteSelection added
    • workbench.action.terminal.paste exists already
  • Registers action with a default keybinding of shift-insert on Linux only
  • Action will be unavailable on Windows / OSX
    • This is consistent with the editor PasteSelectionClipboardAction

@ghost

Deleted user (ghost) commented Oct 9, 2020 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@Tyriar Daniel Imms (Tyriar) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great quality PR! I just need to test it and can merge it in, I'll be looking through all my PRs this and next week.

@Tyriar

Copy link
Copy Markdown
Contributor

Sorry about the delay, I took a bunch of time off work. Pushing to Feb as I don't have access to my work machine with Linux atm.

@joaomoreno
JoΓ£o Moreno (joaomoreno) changed the base branch from master to main February 15, 2021 08:51
@Tyriar Daniel Imms (Tyriar) removed this from the February 2021 milestone Feb 25, 2021
@Tyriar Daniel Imms (Tyriar) added this to the April 2021 milestone Mar 22, 2021

@Tyriar Daniel Imms (Tyriar) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry about the delay, this works great though πŸ‘

@Tyriar
Daniel Imms (Tyriar) merged commit e30424a into microsoft:main Mar 30, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal : support selection buffer paste

3 participants