Skip to content

Add cuda-cpp lang id, grammar and problem matchers - #119444

Merged
Alex Ross (alexr00) merged 14 commits into
microsoft:mainfrom
PooyaZv:nvidia/the-combined-3-cuda-cpp-changes
Mar 30, 2021
Merged

Alex Ross (alexr00) merged 14 commits into
microsoft:mainfrom
PooyaZv:nvidia/the-combined-3-cuda-cpp-changes

Conversation

@PooyaZv

Copy link
Copy Markdown
Contributor

This PR:

  • adds a language ID for cuda-cpp
  • adds a (TextMate) grammar for cuda-cpp
  • adds a problem matcher for cuda-cpp (based on the output of the nvcc compiler)

@ghost

Deleted user (ghost) commented Mar 22, 2021 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@PooyaZv

Copy link
Copy Markdown
Contributor Author

Alex Ross (@alexr00) This PR is our 3 cuda-cpp PRs combined if it is preferred.

@alexr00 Alex Ross (alexr00) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in package.json all look good. The only changes needed are to add a test file and to make sure the new grammar is included in our scripts.

Comment thread extensions/cpp/syntaxes/cuda-cpp.tmLanguage.json Outdated
Comment thread extensions/cpp/package.json
@alexr00

Copy link
Copy Markdown
Member

Evan Pooya Vakeely (@PooyaZv) don't forget to also sign the contributor license agreement (#119444 (comment)).

@alexr00 Alex Ross (alexr00) added this to the April 2021 milestone Mar 23, 2021
@PooyaZv

Evan Pooya Vakeely (PooyaZv) commented Mar 24, 2021 •

Copy link
Copy Markdown
Contributor Author

Alex Ross (@alexr00) I have added the update to update-grammars.js and tested the PR with the latest changes. It's all locked, loaded and ready for merging 😊 Thank you very much for all your help.

@alexr00

Copy link
Copy Markdown
Member

👍 good stuff Evan Pooya Vakeely (@PooyaZv). We're getting ready to release soon, which means the only changes that should be merged are bugfixes. Once we branch for release and reopen main for feature work I'll take one last look and merge (probably on Monday).

@PooyaZv

Copy link
Copy Markdown
Contributor Author

Thank you very much 😊

Comment thread extensions/cpp/cgmanifest.json
@alexr00
Alex Ross (alexr00) merged commit 95420b3 into microsoft:main Mar 30, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants