SQLiteJournal: General error: 1 too many SQL variables

[hranicka]

I've switched our project to Nette\Caching v2.4 due to another bug (issue #18).

But today, an application has failed with PDOException #HY000 SQLSTATE[HY000]: General error: 1 too many SQL variables.

I can't provide error log in RAW HTML output (proprietaly real application), but I can part of Stack Trace as image:

[hranicka]

Does anybody know what's the problem? Is it too many records with tags?

The journal file has been big - about 12 MiB.

Maybe it can be the same problem in SQLiteJournal as in #18 (FileJournal)?

[dg]

@milo why is not here DELETE FROM tags WHERE tag IN?

[hranicka]

@dg There can't be delete because we must return deleted keys, e.g. for files deleting in FileStorage.

So I've replaced "too many SQL variables" with subquery in pull request #26 (with test for the bug).

Please, can you see it? It's a critical bug, we have problems on more projects now.

P. S. Sorry for rebases above (spam)...

[dg]

Btw this change probably makes clean non atomic

[hranicka]

Do you mean that we must load keys and delete records in one transaction?

If we begin transaction before data fetching will be it OK in SQLite?

[dg]

Probably yes and the transaction should be open via BEGIN IMMEDIATE.

[milo]

@hranicka Thanks for fixing this.