With prompt, if no input is specified, the return value is not converted to the requested type - #1517
Merged
Merged
Conversation
Member
|
Looks like there was already a special check for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the passed in default is a string but the type parameter is not a string then click should do its best to convert the default to the requested type.
This becomes an issue when using mypy with click. MyPy will complain if you pass anything but a string for the default. One option is to do a type ignore but that starts to pollute the code quickly if you have a lot of prompts that expect integer values. Fixing this also will prevent some accidental bugs where you use different types with your
typeoption and yourdefault. Click should do its best to honor the requested type.