Forward all user's parameters set in PAGER and improve flag detection - #3777
Merged
Merged
Conversation
kdeldycke
marked this pull request as draft
August 18, 2026 08:12
kdeldycke
force-pushed
the
pager-followups
branch
from
August 18, 2026 09:02
f262de6 to
67e4051
Compare
PAGERPAGER and improve flag detection
PAGER and improve flag detectionPAGER and improve flag detection
kdeldycke
force-pushed
the
pager-followups
branch
from
August 18, 2026 09:06
67e4051 to
2c457b5
Compare
kdeldycke
marked this pull request as ready for review
August 18, 2026 09:07
Collaborator
Author
Just a note re-reading my code, I am not 100% sure that I am covering all the funky edge cases that a user can put in a |
kdeldycke
force-pushed
the
pager-followups
branch
from
August 19, 2026 04:26
2c457b5 to
3f4cbf3
Compare
Improve detection of raw mode by parsing the option tokens Fix detection of `less.exe` on Windows
kdeldycke
force-pushed
the
pager-followups
branch
from
August 19, 2026 04:31
3f4cbf3 to
a6256bf
Compare
Rowlando13
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR following up on pager refactors that:
PAGERless.exeon Windows (even if not currently exercised, this make the method future-proof)But more importantly: adds dozen of testing with weird edge-cases around pager's internal methods.
Follows up on:
_pager_contextmanager#3776