-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
CGU reuse tracking used by incr. comp. testing is inaccurate wrt ThinLTO CGU reuse #119076
Copy link
Copy link
Open
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Activity
Metadata
Metadata
Assignees
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Since #115964, CGU reuse tracking does not report "post-lto" reuse when the compiler discovers that the cached post-LTO version of a CGU can be re-used during the ThinLTO phase in the LLVM backend.
Due to this some tests in https://github.com/rust-lang/rust/tree/cda4736f1eaad8af6f49388baa9b7e480df8e329/tests/incremental/thinlto state "pre-lto" even though we actually expect the "post-lto" artifacts to be reusable. We should look into