Make `AllocatorNightly` less clever - #163590

maxdexh · 2026-10-01T08:58:39Z

r? nia-e

rustbot · 2026-10-01T09:38:31Z

nia-e is currently at their maximum review capacity.
They may take a while to respond.

maxdexh · 2026-10-01T09:38:44Z

cc @lcnr

lcnr

r=me from the types side

View changes since this review

clarfonthey · 2026-10-01T13:36:26Z

r? clarfonthey

@bors r+ rollup

Yeah, this should be fine. You did cover all the impls.

rust-bors · 2026-10-01T13:36:30Z

📌 Commit 3c0c34f has been tentatively approved by clarfonthey

It will be put into the queue for this repository once PR CI succeeds.

rust-bors · 2026-10-01T13:38:17Z

❌ Commit 3c0c34f has been unapproved because PR CI timed out after 7200s.

clarfonthey · 2026-10-01T13:40:21Z

@bors r+

rust-bors · 2026-10-01T13:40:24Z

📌 Commit 3c0c34f has been approved by clarfonthey

It is now in the queue for this repository.

maxdexh · 2026-10-01T13:42:28Z

If we miss an impl, it just means worse usability for nightly users.
We just can't have an AllocatorNightly impl without unstable_feature_bound, except for Global (or downstream, since they need to be on nightly to implement this anyway)

…larfonthey Make `AllocatorNightly` less clever r? nia-e

…uwer Rollup of 9 pull requests Successful merges: - #163461 (Improve diagnostic deduplication) - #159021 (windows-gnu: enable native TLS) - #161467 (wfcheck: name the item that discards an unused type parameter) - #162618 (trait_selection: Preserve eager normalization failures) - #163064 (Avoid computing overflowed goal chains for crate dependencies) - #163360 ([rustdoc] Correctly handle rustc_allow_incoherent_impl on primitive methods) - #163385 (GVN transmutes of Immediate::Uninit to Immediate::Uninit) - #163590 (Make `AllocatorNightly` less clever) - #163599 (Add union pattern reference change to relnotes)

…uwer Rollup of 20 pull requests Successful merges: - #163483 (Bump bootstrap compiler to 1.100.0 beta) - #161380 (only rerun const eval in next-solver if the const actually references opaques) - #162900 (Some refactorings around metadata encoding) - #163461 (Improve diagnostic deduplication) - #163580 (Provide better doc code example for `UnixDatagram::bind_addr` and `UnixListener::bind_addr`) - #163584 ([triagebot] Ping me for debugger visualizer changes) - #159021 (windows-gnu: enable native TLS) - #161467 (wfcheck: name the item that discards an unused type parameter) - #162618 (trait_selection: Preserve eager normalization failures) - #162904 (Fix ICE for ambiguous candidates on method probing) - #163064 (Avoid computing overflowed goal chains for crate dependencies) - #163281 (Add `f16` inline ASM support to `spirv.rs`) - #163314 (move `#[macro_export]` on declarative macro check to `rustc_attr_parsing`) - #163360 ([rustdoc] Correctly handle rustc_allow_incoherent_impl on primitive methods) - #163385 (GVN transmutes of Immediate::Uninit to Immediate::Uninit) - #163405 (Remove some #[linkage] options) - #163530 (`const impl PartialEq` for `f16b`) - #163581 (do not suggest precise capturing when the opaque span is in a macro expansion) - #163590 (Make `AllocatorNightly` less clever) - #163599 (Add union pattern reference change to relnotes)

maxdexh · 2026-10-01T16:17:25Z

Oh also, when we stabilize Arc, we must remember to remove the AllocatorNightly bound on the From<Box> impl. Doing so later is breaking because fundamental types are fun.

lcnr · 2026-10-01T16:32:56Z

maybe put a fixme on Arc next to the unstable generic param in this case?

maxdexh · 2026-10-01T16:34:26Z

good idea, will do in a separate pr

same for Rc

maxdexh · 2026-10-01T16:37:23Z

@lcnr At the risk of being the 1000th person to misunderstand this attribute (in which case, do i get a prize?), maybe we can guard this with a rustc_reservation_impl that uses the weaker Allocator bound?

…uwer Rollup of 20 pull requests Successful merges: - #163483 (Bump bootstrap compiler to 1.100.0 beta) - #161380 (only rerun const eval in next-solver if the const actually references opaques) - #162900 (Some refactorings around metadata encoding) - #163461 (Improve diagnostic deduplication) - #163580 (Provide better doc code example for `UnixDatagram::bind_addr` and `UnixListener::bind_addr`) - #163584 ([triagebot] Ping me for debugger visualizer changes) - #159021 (windows-gnu: enable native TLS) - #161467 (wfcheck: name the item that discards an unused type parameter) - #162618 (trait_selection: Preserve eager normalization failures) - #162904 (Fix ICE for ambiguous candidates on method probing) - #163064 (Avoid computing overflowed goal chains for crate dependencies) - #163281 (Add `f16` inline ASM support to `spirv.rs`) - #163314 (move `#[macro_export]` on declarative macro check to `rustc_attr_parsing`) - #163360 ([rustdoc] Correctly handle rustc_allow_incoherent_impl on primitive methods) - #163385 (GVN transmutes of Immediate::Uninit to Immediate::Uninit) - #163405 (Remove some #[linkage] options) - #163530 (`const impl PartialEq` for `f16b`) - #163581 (do not suggest precise capturing when the opaque span is in a macro expansion) - #163590 (Make `AllocatorNightly` less clever) - #163599 (Add union pattern reference change to relnotes)

mejrs · 2026-10-01T20:24:12Z

Didn't we remove rustc_reservation_impl?

maxdexh · 2026-10-01T20:27:41Z

it's still in some tests, so idk

clarfonthey · 2026-10-01T21:12:33Z

It should be actually gone, so, shouldn't work.

maxdexh · 2026-10-01T21:13:40Z

rip those tests ig

clarfonthey · 2026-10-01T21:17:19Z

cc @WaffleLapkin as part of the Tell Waffle Initiative

since you removed the attribute

…uwer Rollup of 20 pull requests Successful merges: - #163483 (Bump bootstrap compiler to 1.100.0 beta) - #161380 (only rerun const eval in next-solver if the const actually references opaques) - #162900 (Some refactorings around metadata encoding) - #163461 (Improve diagnostic deduplication) - #163580 (Provide better doc code example for `UnixDatagram::bind_addr` and `UnixListener::bind_addr`) - #163584 ([triagebot] Ping me for debugger visualizer changes) - #159021 (windows-gnu: enable native TLS) - #161467 (wfcheck: name the item that discards an unused type parameter) - #162618 (trait_selection: Preserve eager normalization failures) - #162904 (Fix ICE for ambiguous candidates on method probing) - #163064 (Avoid computing overflowed goal chains for crate dependencies) - #163281 (Add `f16` inline ASM support to `spirv.rs`) - #163314 (move `#[macro_export]` on declarative macro check to `rustc_attr_parsing`) - #163360 ([rustdoc] Correctly handle rustc_allow_incoherent_impl on primitive methods) - #163385 (GVN transmutes of Immediate::Uninit to Immediate::Uninit) - #163405 (Remove some #[linkage] options) - #163530 (`const impl PartialEq` for `f16b`) - #163581 (do not suggest precise capturing when the opaque span is in a macro expansion) - #163590 (Make `AllocatorNightly` less clever) - #163599 (Add union pattern reference change to relnotes)

nia-e

late to the party but lgtm as well. ty!

View changes since this review

Rollup merge of #163590 - maxdexh:allocator-nightly-sad, r=clarfonthey Make `AllocatorNightly` less clever r? nia-e

…uwer Rollup of 20 pull requests Successful merges: - rust-lang/rust#163483 (Bump bootstrap compiler to 1.100.0 beta) - rust-lang/rust#161380 (only rerun const eval in next-solver if the const actually references opaques) - rust-lang/rust#162900 (Some refactorings around metadata encoding) - rust-lang/rust#163461 (Improve diagnostic deduplication) - rust-lang/rust#163580 (Provide better doc code example for `UnixDatagram::bind_addr` and `UnixListener::bind_addr`) - rust-lang/rust#163584 ([triagebot] Ping me for debugger visualizer changes) - rust-lang/rust#159021 (windows-gnu: enable native TLS) - rust-lang/rust#161467 (wfcheck: name the item that discards an unused type parameter) - rust-lang/rust#162618 (trait_selection: Preserve eager normalization failures) - rust-lang/rust#162904 (Fix ICE for ambiguous candidates on method probing) - rust-lang/rust#163064 (Avoid computing overflowed goal chains for crate dependencies) - rust-lang/rust#163281 (Add `f16` inline ASM support to `spirv.rs`) - rust-lang/rust#163314 (move `#[macro_export]` on declarative macro check to `rustc_attr_parsing`) - rust-lang/rust#163360 ([rustdoc] Correctly handle rustc_allow_incoherent_impl on primitive methods) - rust-lang/rust#163385 (GVN transmutes of Immediate::Uninit to Immediate::Uninit) - rust-lang/rust#163405 (Remove some #[linkage] options) - rust-lang/rust#163530 (`const impl PartialEq` for `f16b`) - rust-lang/rust#163581 (do not suggest precise capturing when the opaque span is in a macro expansion) - rust-lang/rust#163590 (Make `AllocatorNightly` less clever) - rust-lang/rust#163599 (Add union pattern reference change to relnotes)

…they Add some comments and docs related to `AllocatorNightly` Follow-up to rust-lang#163590 (comment) and [this zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/197181-t-libs.2Fwg-allocators/topic/.60AllocatorNightly.60.20auto-trait.3F/near/629283171)

Rollup merge of #163814 - maxdexh:allocator-daily, r=clarfonthey Add some comments and docs related to `AllocatorNightly` Follow-up to #163590 (comment) and [this zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/197181-t-libs.2Fwg-allocators/topic/.60AllocatorNightly.60.20auto-trait.3F/near/629283171)

…uwer Rollup of 20 pull requests Successful merges: - rust-lang/rust#163483 (Bump bootstrap compiler to 1.100.0 beta) - rust-lang/rust#161380 (only rerun const eval in next-solver if the const actually references opaques) - rust-lang/rust#162900 (Some refactorings around metadata encoding) - rust-lang/rust#163461 (Improve diagnostic deduplication) - rust-lang/rust#163580 (Provide better doc code example for `UnixDatagram::bind_addr` and `UnixListener::bind_addr`) - rust-lang/rust#163584 ([triagebot] Ping me for debugger visualizer changes) - rust-lang/rust#159021 (windows-gnu: enable native TLS) - rust-lang/rust#161467 (wfcheck: name the item that discards an unused type parameter) - rust-lang/rust#162618 (trait_selection: Preserve eager normalization failures) - rust-lang/rust#162904 (Fix ICE for ambiguous candidates on method probing) - rust-lang/rust#163064 (Avoid computing overflowed goal chains for crate dependencies) - rust-lang/rust#163281 (Add `f16` inline ASM support to `spirv.rs`) - rust-lang/rust#163314 (move `#[macro_export]` on declarative macro check to `rustc_attr_parsing`) - rust-lang/rust#163360 ([rustdoc] Correctly handle rustc_allow_incoherent_impl on primitive methods) - rust-lang/rust#163385 (GVN transmutes of Immediate::Uninit to Immediate::Uninit) - rust-lang/rust#163405 (Remove some #[linkage] options) - rust-lang/rust#163530 (`const impl PartialEq` for `f16b`) - rust-lang/rust#163581 (do not suggest precise capturing when the opaque span is in a macro expansion) - rust-lang/rust#163590 (Make `AllocatorNightly` less clever) - rust-lang/rust#163599 (Add union pattern reference change to relnotes)

Make AllocatorNightly less clever

3c0c34f

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 1, 2026

maxdexh mentioned this pull request Oct 1, 2026

remove AllocatorNightly blanket impl #163588

Closed

rustbot assigned nia-e Oct 1, 2026

maxdexh marked this pull request as ready for review October 1, 2026 09:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2026

lcnr approved these changes Oct 1, 2026

View reviewed changes

rustbot assigned clarfonthey Oct 1, 2026

rustbot unassigned nia-e Oct 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 1, 2026

Rollup merge of rust-lang#163590 - maxdexh:allocator-nightly-sad, r=c…

6b68e3b

…larfonthey Make `AllocatorNightly` less clever r? nia-e

JonathanBrouwer mentioned this pull request Oct 1, 2026

Rollup of 9 pull requests #163605

Closed

JonathanBrouwer mentioned this pull request Oct 1, 2026

Rollup of 20 pull requests #163609

Merged

nia-e approved these changes Oct 2, 2026

View reviewed changes

rust-bors Bot merged commit d0fb4c3 into rust-lang:main Oct 2, 2026
13 checks passed

rustbot added this to the 1.101.0 milestone Oct 2, 2026

rust-bors Bot pushed a commit that referenced this pull request Oct 2, 2026

Unrolled build for #163590 in rollup 163609

90042fe

Rollup merge of #163590 - maxdexh:allocator-nightly-sad, r=clarfonthey Make `AllocatorNightly` less clever r? nia-e

maxdexh deleted the allocator-nightly-sad branch October 2, 2026 06:33

maxdexh mentioned this pull request Oct 5, 2026

Add some comments and docs related to AllocatorNightly #163814

Merged

Conversation

maxdexh commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 1, 2026

Uh oh!

maxdexh commented Oct 1, 2026

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clarfonthey commented Oct 1, 2026

Uh oh!

rust-bors Bot commented Oct 1, 2026

Uh oh!

rust-bors Bot commented Oct 1, 2026

Uh oh!

clarfonthey commented Oct 1, 2026

Uh oh!

rust-bors Bot commented Oct 1, 2026

Uh oh!

maxdexh commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxdexh commented Oct 1, 2026

Uh oh!

lcnr commented Oct 1, 2026

Uh oh!

maxdexh commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxdexh commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mejrs commented Oct 1, 2026

Uh oh!

maxdexh commented Oct 1, 2026

Uh oh!

clarfonthey commented Oct 1, 2026

Uh oh!

maxdexh commented Oct 1, 2026

Uh oh!

clarfonthey commented Oct 1, 2026

Uh oh!

nia-e left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

maxdexh commented Oct 1, 2026 •

edited

Loading

lcnr left a comment •

edited by rustbot

Loading

maxdexh commented Oct 1, 2026 •

edited

Loading

maxdexh commented Oct 1, 2026 •

edited

Loading

maxdexh commented Oct 1, 2026 •

edited

Loading

nia-e left a comment •

edited by rustbot

Loading