Rollup of 4 pull requests - #163793

JonathanBrouwer · 2026-10-05T09:23:10Z

Successful merges:

miri subtree update #163790 (miri subtree update)
optimize empty NestedGoals::extend_from_child #163610 (optimize empty NestedGoals::extend_from_child)
cg_llvm: Use LLVMGlobalAddMetadata from LLVM-C #163697 (cg_llvm: Use LLVMGlobalAddMetadata from LLVM-C)
lower spans of error const args and test binder bounds #163750 (lower spans of error const args and test binder bounds)

dynamically test for symlink permission

As the comments explain, `Span` does not implement `Send` and so Miri had to store `SpanData` (which does implement `Send`) instead, so certain other types are `Send`. At least, that used to be true. When the serial rustc front-end was removed `Span` became `Send`. So now Miri can store `Span`, which is much more standard than storing `SpanData`.

This updates the rust-version file to 837b18a.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@837b18a Filtered ref: rust-lang/miri@7edc483 Upstream diff: rust-lang/rust@5c543b0...837b18a This merge was created using https://github.com/rust-lang/josh-sync.

This reverts commit ab956667801480a745969fedced5dd5c92372a49.

Store `Span` instead of `SpanData`

rustup, restore FreeBSD test

Add native FreeBSD runner to CI

remove some unnecessary @only-on-host

make Linux current_exe work on non-Linux hosts

Make tests work offline

getaddrinfo test: ensure we see both IPv4 and IPv6

bump dependencies

pick more sensible path for current_exe

This updates the rust-version file to e0452e2.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@837b18a New upstream ref: rust-lang/rust@e0452e2 Filtered ref: rust-lang/miri@b586a31 Upstream diff: rust-lang/rust@837b18a...e0452e2 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

this helps with File debug-printing on Linux (but not on other Unixes)

unix open: support opening directories

solarish: support current_exe via /proc/self/path/a.out in readlink.

This function was added in LLVM 22.

@ghost

miri subtree update Subtree update of `miri` to rust-lang/miri@39f6500. Created using https://github.com/rust-lang/josh-sync. r? @ghost

optimize empty `NestedGoals::extend_from_child` we sometimes get incredibly big `nested_goals` from large and involved cycles. When propagating them outwards, we currently manually build a `HashMap` by accessing an entry for every nested goal of the child. This is unnecessary. This does not help with the max-rss regression in rust-lang#161660, but should help with perf in such cases. r? types

cg_llvm: Use `LLVMGlobalAddMetadata` from LLVM-C - Follow-up to rust-lang#163572 --- `LLVMGlobalAddMetadata` was introduced in LLVM 22, so now that that's our baseline, we can bind to it directly and remove our own C++ wrapper.

@bjorn3

… r=oli-obk lower spans of error const args and test binder bounds fixes rust-lang#163592 lower spans when constructing hir nodes for error const args and test binder bound type constraints, these paths were using raw ast spans instead of routing them through `lower_span` (reproduce with `rust.debug-assertions = true` and `-Cincremental`; the tests listed in the issue now pass.) r? @bjorn3 cc @matthiaskrgr

JonathanBrouwer · 2026-10-05T09:23:21Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

rust-bors · 2026-10-05T09:23:25Z

📌 Commit b9eb49a has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 4 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu

rust-bors · 2026-10-05T12:23:13Z

☀️ Try build successful (CI)
Build commit: 281bcf4 (281bcf4e4fde84e9b122b02443ee904cca53036f)
Base parent: 4d13b68 (4d13b68badbf76e5c7831291e8fb324eabae2626)

rust-bors · 2026-10-05T13:36:30Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 11m 43s
Pushing 602727f to main...

github-actions · 2026-10-05T13:40:08Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4d13b68 (parent) -> 602727f (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 602727f26878dcf9eb2999e2f58e5df1269ff47e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-x86_64-gnu-debug: 1h 15m -> 2h 9m (+72.1%)
dist-loongarch64-musl: 1h 16m -> 2h 6m (+66.3%)
dist-x86_64-mingw: 1h 45m -> 2h 51m (+62.4%)
test-x86_64-gnu-aux: 1h 35m -> 2h 34m (+61.7%)
dist-various-1: 34m 23s -> 52m 4s (+51.4%)
dist-powerpc64-linux-gnu: 1h 5m -> 1h 31m (+40.4%)
dist-x86_64-msvc-alt: 2h 8m -> 2h 53m (+35.8%)
test-i686-gnu-nopt-2: 2h 14m -> 1h 28m (-34.3%)
dist-arm-linux-gnueabi: 1h 10m -> 1h 34m (+34.0%)
dist-ohos-aarch64: 1h 21m -> 54m 7s (-33.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-10-05T14:20:41Z

Finished benchmarking commit (602727f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary 0.3%, secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-3.0%	[-3.8%, -2.2%]	3
All ❌✅ (primary)	0.3%	[-2.1%, 2.7%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 488.486s -> 490.152s (0.34%)
Artifact size: 408.62 MiB -> 408.63 MiB (0.00%)

rust-bors · 2026-10-05T14:41:02Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#163790	miri subtree update	`aced59b3d96d83935e6ddd131716f22bf0be55eb` (link)
#163610	optimize empty `NestedGoals::extend_from_child`	`b37d5b8b69a7c3188f57ac7aa65593e3193862ee` (link)
#163697	cg_llvm: Use `LLVMGlobalAddMetadata` from LLVM-C	`230efc4173925bd37e8008e935f114874a8b3f8f` (link)
#163750	lower spans of error const args and test binder bounds	`fdb64247f984698506a6afd26c15dfffdaadef94` (link)

parent commit: 4d13b68bad

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

RalfJung and others added 30 commits September 30, 2026 23:44

dynamically test for symlink permission

584a710

Merge pull request rust-lang#5365 from RalfJung/symink-perm

21aaaf0

dynamically test for symlink permission

Add native FreeBSD runner to CI

cef096d

Prepare for merging from rust-lang/rust

fdc7532

This updates the rust-version file to 837b18a.

Revert "temporarily disable broken test on freebsd"

a8a8111

This reverts commit ab956667801480a745969fedced5dd5c92372a49.

Merge pull request rust-lang#5366 from nnethercote/store-Span

b433834

Store `Span` instead of `SpanData`

Merge pull request rust-lang#5368 from RalfJung/freebsd-numcpu

86aed35

rustup, restore FreeBSD test

freebsd: add FIXME for st_mode on a pipe

d4c82e7

Merge pull request rust-lang#5354 from WhySoBad/native-freebsd-ci

9777590

Add native FreeBSD runner to CI

Handle ENETUNREACH in socket tests which connect to blackhole addresses

9cab556

remove some unnecessary @only-on-host

545a884

Merge pull request rust-lang#5372 from RalfJung/only-on-host

54ef8ec

remove some unnecessary @only-on-host

make Linux current_exe work on non-Linux hosts

4bf4c94

Merge pull request rust-lang#5373 from RalfJung/linux-current-exe

e62ff22

make Linux current_exe work on non-Linux hosts

Merge pull request rust-lang#5369 from WhySoBad/handle-enetunreach

6ef28db

Make tests work offline

getaddrinfo test: ensure we see both IPv4 and IPv6

da9fe25

Merge pull request rust-lang#5376 from RalfJung/getaddrinfo-test

97b9a27

getaddrinfo test: ensure we see both IPv4 and IPv6

bump dependencies

422a964

Merge pull request rust-lang#5377 from RalfJung/deps

42a105c

bump dependencies

pick more sensible path for current_exe

b592ad4

we have to normalize stderr as well

f04ffd9

run some more tests natively

ef66a06

Merge pull request rust-lang#5378 from RalfJung/current_exe

15471df

pick more sensible path for current_exe

Prepare for merging from rust-lang/rust

52e14c7

This updates the rust-version file to e0452e2.

fmt

5e524bb

Merge pull request rust-lang#5380 from rust-lang/rustup-2026-10-03

5342681

Automatic Rustup

unix open: support opening directories

bfbfe1e

RalfJung and others added 10 commits October 4, 2026 11:26

support F_GETFL on files and directories

4e604a9

this helps with File debug-printing on Linux (but not on other Unixes)

Merge pull request rust-lang#5382 from RalfJung/unix-open-dir

8c4ce2e

unix open: support opening directories

Merge pull request rust-lang#5383 from devnexen/solarish_current_exe

a9b166b

solarish: support current_exe via /proc/self/path/a.out in readlink.

lower spans of error const args and test binder bounds

63c07bd

Use LLVMGlobalAddMetadata

58eda6e

This function was added in LLVM 22.

optimize empty NestedGoals::extend_from_child

9c4bef5

Rollup merge of rust-lang#163790 - RalfJung:miri, r=RalfJung

13c0a61

miri subtree update Subtree update of `miri` to rust-lang/miri@39f6500. Created using https://github.com/rust-lang/josh-sync. r? @ghost

rust-bors Bot added the rollup A PR which is a rollup label Oct 5, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 5, 2026

rust-bors Bot merged commit 602727f into rust-lang:main Oct 5, 2026
16 checks passed

rustbot added this to the 1.101.0 milestone Oct 5, 2026

Navigation Menu

Uh oh!

Rollup of 4 pull requests - #163793