Decompositions for reduceLogSum, reduceLogSumExp, and reduceSumSquare - #637
Merged
Merged
Conversation
As noted in #209, not all frameworks/platform APIs support all reduce operations, but these are easily emulated. Decompositions are provided using the standard phrasing and style currently used throughout the spec. In the future, we may alter the wording to explicitly state that these decompositions can be used as templates for implementations to follow when their underlying frameworks/platform APIs do not support the operations. Fixes #209
huningxin
approved these changes
Apr 6, 2024
huningxin
left a comment
huningxin
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a nit, thanks!
Co-authored-by: Ningxin Hu <ningxin.hu@intel.com>
fdwr
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #209, not all frameworks/platform APIs support all reduce operations, but these are easily emulated.
Decompositions are provided using the standard phrasing and style currently used throughout the spec. In the future, we may alter the wording to explicitly state that these decompositions can be used as templates for implementations to follow when their underlying frameworks/platform APIs do not support the operations.
Fixes #209
Preview | Diff