Skip to content

Clarify division operator rounding - #909

Merged
fdwr merged 2 commits into
webmachinelearning:mainfrom
fdwr:user/dwayner/DivClarifyTowardZero
Dec 12, 2025
Merged

fdwr merged 2 commits into
webmachinelearning:mainfrom
fdwr:user/dwayner/DivClarifyTowardZero

Conversation

@fdwr

@fdwr fdwr commented Dec 9, 2025 •

Copy link
Copy Markdown
Collaborator

Minor clarification that div expects to round toward zero (truncation), rather than say being floored to negative zero like Numpy's floor_divide.


Preview | Diff

@fdwr

fdwr commented Dec 9, 2025 •

Copy link
Copy Markdown
Collaborator Author
 $ bikeshed --die-on=warning spec "index.bs" "index.bs.built.html" 
  FATAL ERROR: Line 8439 isn't indented enough (needs 1 indent) to be valid Markdown:
  "</dl>"
   ✘  Did not generate, due to errors exceeding the allowed error level.

Err, this line in MLResample2dOptions hasn't changed for 10 months, and its indentation count does align with the opening <dl> on line 8410. 🤔 I wonder if this is a new bikeshed change. I don't see it in previous PR's. Will need to play around with it... ⏳

@dontcallmedom

Copy link
Copy Markdown
Contributor

re bikeshed error, see https://lists.w3.org/Archives/Public/spec-prod/2025OctDec/thread.html#msg4 - bikeshed updates including in the parsing code

@anssiko

anssiko commented Dec 9, 2025

Copy link
Copy Markdown
Member

Indentation is indeed correct. One possible workaround is to add an empty line before the closing </dl> on line 8439.

@fdwr

fdwr commented Dec 9, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks @dontcallmedom and @anssiko 👍.

@fdwr

fdwr commented Dec 12, 2025 •

Copy link
Copy Markdown
Collaborator Author

@huningxin : I'm going to merge this as it's really minor editorial, and it cleans up the build failure for Bruce's PR too. If you have any feedback, I'll follow up with a new PR.

@fdwr
fdwr merged commit 94bcacb into webmachinelearning:main Dec 12, 2025
2 checks passed
github-actions Bot added a commit that referenced this pull request Dec 12, 2025
SHA: 94bcacb
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants