feat: reuse an already active MultiWatching - #2371
Merged
Merged
Conversation
webpack 5.109 exposes the active MultiWatching on MultiCompiler.watching, resolving the old TODO here: when watching was already started (by webpack-cli or the user), the middleware now adopts that session instead of starting a second one — double watchers meant duplicate builds. Older webpack versions fall back to watch() as before. Also updates the logging snapshots for webpack 5.109's runtime size changes (KiB/bytes boundary shifts in stats output).
🦋 Changeset detectedLatest commit: 95d7b0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
==========================================
+ Coverage 92.60% 92.70% +0.09%
==========================================
Files 3 3
Lines 1001 1001
Branches 311 311
==========================================
+ Hits 927 928 +1
+ Misses 66 65 -1
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bjohansebas
marked this pull request as ready for review
July 25, 2026 04:52
alexander-akait
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webpack 5.109 exposes the active MultiWatching on MultiCompiler.watching, resolving the old TODO here: when watching was already started (by webpack-cli or the user), the middleware now adopts that session instead of starting a second one — double watchers meant duplicate builds. Older webpack versions fall back to watch() as before.
Also updates the logging snapshots for webpack 5.109's runtime size changes (KiB/bytes boundary shifts in stats output).
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI