Update our deploy action to run under node 16#116
Merged
Conversation
…o the latest version
dkotter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Our
Deploy to WordPress.orgaction is failing and it appears to be an issue with the node version that the action runs under and the webpack version the plugin uses to build assets.Found this answer that talks about changes in node v17+ that conflict with webpack v4. While it would be ideal to update this plugin to use the latest version of webpack, the easy approach for now is to run our deploy action under node 16.
How to test the Change
Can't test for sure until we trigger the deploy action but you can test locally by installing node 16 and running
npm run build-release. That command should work, though it will output some CSS warnings.