Skip to content

Comments

feat(udf)!: deprecate functions fz_{fn}#2818

Merged
lumianph merged 5 commits into4paradigm:mainfrom
aceforeverd:feat-deprecate-fz-func
Mar 6, 2023
Merged

feat(udf)!: deprecate functions fz_{fn}#2818
lumianph merged 5 commits into4paradigm:mainfrom
aceforeverd:feat-deprecate-fz-func

Conversation

@aceforeverd
Copy link
Collaborator

use {fn} instead

Pls note this is a breaking change, should only available since 0.7.0

@github-actions github-actions bot added the execute-engine hybridse sql engine label Nov 24, 2022
@aceforeverd aceforeverd added this to the v0.7 milestone Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 76.05% // Head: 36.74% // Decreases project coverage by -39.31% ⚠️

Coverage data is based on head (71617c4) compared to base (e7c445c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2818       +/-   ##
=============================================
- Coverage     76.05%   36.74%   -39.32%     
  Complexity      393      393               
=============================================
  Files           648      156      -492     
  Lines        122509     9264   -113245     
  Branches       1083     1083               
=============================================
- Hits          93174     3404    -89770     
+ Misses        29099     5624    -23475     
  Partials        236      236               
Impacted Files Coverage Δ
hybridse/src/udf/default_defs/feature_zero_def.cc
hybridse/src/udf/udf_test.cc
src/nameserver/name_server_create_remote_test.cc
src/codec/codec.h
src/cmd/single_tablet_test.cc
hybridse/src/udf/default_udf_library.cc
hybridse/src/vm/jit_runtime.cc
src/sdk/sql_cache.cc
src/client/tablet_client.cc
hybridse/src/vm/transform_request_mode_test.cc
... and 482 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

SDK Test Report

  83 files    83 suites   1m 28s ⏱️
176 tests 170 ✔️ 6 💤 0
222 runs  216 ✔️ 6 💤 0

Results for commit 71617c4.

@github-actions
Copy link
Contributor

Linux Test Report

583 tests   576 ✔️  27m 5s ⏱️
  58 suites      7 💤
  52 files        0

Results for commit 71617c4.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

19 807 tests   19 690 ✔️  8m 21s ⏱️
     239 suites           2 💤
       66 files         115

For more details on these failures, see this check.

Results for commit 71617c4.

@github-actions
Copy link
Contributor

HybridSE Linux Test Report

19 807 tests   19 690 ✔️  6m 29s ⏱️
     239 suites           2 💤
       66 files         115

For more details on these failures, see this check.

Results for commit 71617c4.

@lumianph lumianph enabled auto-merge (squash) February 13, 2023 13:50
@lumianph
Copy link
Collaborator

let's resolve the conflict and merge this pr asap @aceforeverd

@aceforeverd
Copy link
Collaborator Author

let's resolve the conflict and merge this pr asap @aceforeverd

all right. But we must highlight the breaking change.

@aceforeverd aceforeverd force-pushed the feat-deprecate-fz-func branch from 71617c4 to 05682ab Compare March 6, 2023 08:53
@lumianph lumianph merged commit 5530097 into 4paradigm:main Mar 6, 2023
@github-actions github-actions bot added batch-engine openmldb batch(offline) engine docker openmldb compile image or demo image labels Mar 6, 2023
aceforeverd added a commit to aceforeverd/fedb that referenced this pull request Mar 6, 2023
tobegit3hub pushed a commit that referenced this pull request Mar 7, 2023
* Revert "feat(udf)!: deprecate functions `fz_{fn}` (#2818)"

This reverts commit 5530097.

* fix: fz_fn -> fn change
@aceforeverd aceforeverd deleted the feat-deprecate-fz-func branch April 6, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

batch-engine openmldb batch(offline) engine docker openmldb compile image or demo image execute-engine hybridse sql engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants