Skip to content

Comments

fix: taskmanager io/work thread config#3231

Merged
aceforeverd merged 1 commit intomainfrom
vagetablechicken-patch-1
Apr 26, 2023
Merged

fix: taskmanager io/work thread config#3231
aceforeverd merged 1 commit intomainfrom
vagetablechicken-patch-1

Conversation

@vagetablechicken
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the task-manager openmldb taskmanager label Apr 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2023

SDK Test Report

  96 files  ±0    96 suites  ±0   1m 42s ⏱️ +4s
187 tests ±0  177 ✔️ ±0  10 💤 ±0  0 ±0 
233 runs  ±0  223 ✔️ ±0  10 💤 ±0  0 ±0 

Results for commit 6342c01. ± Comparison against base commit 168f8c9.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (168f8c9) 75.61% compared to head (6342c01) 75.62%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3231      +/-   ##
============================================
+ Coverage     75.61%   75.62%   +0.01%     
  Complexity      393      393              
============================================
  Files           681      679       -2     
  Lines        125633   125452     -181     
  Branches       1181     1181              
============================================
- Hits          94995    94872     -123     
+ Misses        30402    30360      -42     
+ Partials        236      220      -16     
Impacted Files Coverage Δ
...openmldb/taskmanager/server/TaskManagerServer.java 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files  ±0       234 suites  ±0   1h 13m 23s ⏱️ - 3m 35s
12 017 tests ±0  12 010 ✔️ ±0  7 💤 ±0  0 ±0 
17 059 runs  ±0  17 052 ✔️ ±0  7 💤 ±0  0 ±0 

Results for commit 6342c01. ± Comparison against base commit 168f8c9.

@aceforeverd aceforeverd merged commit f66c931 into main Apr 26, 2023
@aceforeverd aceforeverd deleted the vagetablechicken-patch-1 branch April 26, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task-manager openmldb taskmanager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants