Skip to content

Comments

feat: support multi db in parse and add getDependenceTables#3314

Merged
vagetablechicken merged 38 commits into4paradigm:mainfrom
vagetablechicken:multidb-pr
Jun 25, 2023
Merged

feat: support multi db in parse and add getDependenceTables#3314
vagetablechicken merged 38 commits into4paradigm:mainfrom
vagetablechicken:multidb-pr

Conversation

@vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Jun 13, 2023

close #611, close #3304

@github-actions github-actions bot added documentation Improvements or additions to documentation sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet labels Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 79.89% and project coverage change: -0.05 ⚠️

Comparison is base (bf4e614) 75.55% compared to head (36cfed8) 75.50%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3314      +/-   ##
============================================
- Coverage     75.55%   75.50%   -0.05%     
- Complexity      411      414       +3     
============================================
  Files           693      693              
  Lines        125974   126076     +102     
  Branches       1185     1189       +4     
============================================
+ Hits          95175    95197      +22     
- Misses        30561    30638      +77     
- Partials        238      241       +3     
Impacted Files Coverage Δ
src/base/ddl_parser.h 100.00% <ø> (ø)
src/client/ns_client.h 100.00% <ø> (ø)
src/sdk/sql_cluster_router.h 0.00% <ø> (ø)
src/sdk/sql_router.cc 2.40% <0.00%> (-0.43%) ⬇️
src/sdk/sql_router.h 42.85% <ø> (ø)
src/tablet/tablet_impl.cc 65.34% <44.44%> (-0.06%) ⬇️
src/catalog/tablet_catalog.cc 71.61% <66.66%> (+0.07%) ⬆️
src/cmd/sql_cmd.h 28.05% <81.81%> (+2.13%) ⬆️
src/base/ddl_parser.cc 77.38% <85.85%> (-0.51%) ⬇️
src/base/ddl_parser_test.cc 92.62% <86.00%> (-2.08%) ⬇️
... and 5 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the workflow CICD related label Jun 16, 2023
@github-actions github-actions bot removed the workflow CICD related label Jun 19, 2023
@vagetablechicken vagetablechicken enabled auto-merge (squash) June 25, 2023 07:05
@vagetablechicken vagetablechicken merged commit 4b88184 into 4paradigm:main Jun 25, 2023
@vagetablechicken vagetablechicken deleted the multidb-pr branch June 25, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy SQL with database name will throw error message ExtractIndexes support multi-db

3 participants