fix(udf): try abs path after dlopen failed and more error catch#3359
fix(udf): try abs path after dlopen failed and more error catch#3359vagetablechicken merged 1 commit intomainfrom
Conversation
SDK Test Report 98 files ±0 98 suites ±0 1m 56s ⏱️ -20s Results for commit 4af6b14. ± Comparison against base commit 5ad050f. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
============================================
- Coverage 75.65% 75.62% -0.03%
Complexity 414 414
============================================
Files 690 692 +2
Lines 125894 126083 +189
Branches 1206 1206
============================================
+ Hits 95242 95354 +112
- Misses 30427 30488 +61
- Partials 225 241 +16
☔ View full report in Codecov by Sentry. |
HybridSE Mac Test Report19 676 tests - 30 19 674 ✔️ - 30 9m 47s ⏱️ -33s Results for commit 4af6b14. ± Comparison against base commit 5ad050f. This pull request removes 30 tests. |
| err_msg = "can not open the dynamic library: " + file + ", error: " + dlerror() + ", try to use abs path"; | ||
| LOG(WARNING) << err_msg; | ||
| // try to use abs path to avoid dlopen failed but it only works in the same path(e.g. in yarn mode) | ||
| char abs_path_buff[PATH_MAX]; |
There was a problem hiding this comment.
reset errno to 0 here
There was a problem hiding this comment.
https://linux.die.net/man/3/realpath
`If there is no error, realpath() returns a pointer to the resolved_path.
Otherwise, it returns a NULL pointer, the contents of the array resolved_path are undefined, and errno is set to indicate the error.`
set 0 before realpath is meaningless
No description provided.