Skip to content

Comments

build(cxx): fix cmake configure on cmake 3.18#3367

Merged
aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd:build-cmake-3.18
Jul 27, 2023
Merged

build(cxx): fix cmake configure on cmake 3.18#3367
aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd:build-cmake-3.18

Conversation

@aceforeverd
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added build openmldb compiling and installing storage-engine openmldb storage engine. nameserver & tablet labels Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2b6e630) 75.62% compared to head (712163e) 75.63%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3367   +/-   ##
=========================================
  Coverage     75.62%   75.63%           
  Complexity      414      414           
=========================================
  Files           692      692           
  Lines        126093   126093           
  Branches       1206     1206           
=========================================
+ Hits          95364    95365    +1     
+ Misses        30488    30487    -1     
  Partials        241      241           

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aceforeverd aceforeverd requested a review from dl239 July 18, 2023 04:40
@aceforeverd aceforeverd changed the title build(cxx): cmake configure on cmake 3.18 build(cxx): fix cmake configure on cmake 3.18 Jul 18, 2023
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit ba61354 into 4paradigm:main Jul 27, 2023
@aceforeverd aceforeverd deleted the build-cmake-3.18 branch July 27, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build openmldb compiling and installing storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants