fix(codegen): handle nullable for date type#3543
Merged
aceforeverd merged 2 commits into4paradigm:mainfrom Oct 23, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3543 +/- ##
============================================
- Coverage 75.33% 75.32% -0.01%
Complexity 587 587
============================================
Files 716 716
Lines 129651 129654 +3
Branches 1280 1280
============================================
- Hits 97672 97665 -7
- Misses 31693 31703 +10
Partials 286 286
☔ View full report in Codecov by Sentry. |
Also fix include headers
8b61af7 to
f183cc8
Compare
always returns allocated structure even it is null, for the cases: 1. construct timestamp from number, even number is < 0 2. construct date from timestamp, even timestamp is null
vagetablechicken
approved these changes
Oct 12, 2023
lqy222
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix include headers as iwyu.
Fixes #3194
More general problem is described in #926, which should handling later
always returns allocated structure even it is null, for the cases: