Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3576 +/- ##
=============================================
+ Coverage 40.14% 75.39% +35.25%
Complexity 635 635
=============================================
Files 191 727 +536
Lines 11207 130597 +119390
Branches 1317 1317
=============================================
+ Hits 4499 98468 +93969
- Misses 6417 31838 +25421
Partials 291 291 ☔ View full report in Codecov by Sentry. |
1437ce9 to
f63f85d
Compare
5e255d1 to
f315fd2
Compare
e5e4d64 to
927744e
Compare
lqy222
approved these changes
Nov 14, 2023
dl239
approved these changes
Nov 15, 2023
runner.cc is too large, sepreate RunnerBuilder, RunnerContext, Runner and ClusterTask in difference files
For REQUESTJOIN(ANY1(T1), ANY2(T2)), ANY1 may optimize T1, REQUESTJOIN, ANY2 may optimize T2, building cluster task correctly
927744e to
eab8951
Compare
This was referenced Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of a LEFT OUTER JOIN (or simply LEFT JOIN) for two from_items always retains all rows of the left from_item in the JOIN operation, even if no rows in the right from_item satisfy the join predicate.
Syntax
Example:
Online Requirements
A simple LEFT JOIN can not online directly, since it always outputs a table. But LEFT JOIN can ack as a subquery inside other queries, currently we only consider LAST JOIN (maybe work on WINDOW or WINDOW UNION later)
LEFT JOIN can be the right source of a LAST JOIN query, format of