Skip to content

Comments

feat(sql router): add interface for sql to dag#3630

Merged
aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd:feat-sql-to-dag
Jan 8, 2024
Merged

feat(sql router): add interface for sql to dag#3630
aceforeverd merged 1 commit into4paradigm:mainfrom
aceforeverd:feat-sql-to-dag

Conversation

@aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Nov 27, 2023

DAG SQLToDAG(const std::string& sql, hybridse::sdk::Status* status);

@github-actions github-actions bot added sdk openmldb java/python sdk execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Nov 27, 2023
@codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (a8c0226) 40.16% compared to head (d33c5d5) 74.90%.

Files Patch % Lines
src/sdk/sql_router.cc 0.00% 53 Missing ⚠️
...paradigm/openmldb/sdk/impl/SqlClusterExecutor.java 84.61% 1 Missing and 1 partial ⚠️
src/sdk/sql_router.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3630       +/-   ##
=============================================
+ Coverage     40.16%   74.90%   +34.74%     
- Complexity      640      644        +4     
=============================================
  Files           191      725      +534     
  Lines         11233   130840   +119607     
  Branches       1325     1327        +2     
=============================================
+ Hits           4512    98012    +93500     
- Misses         6428    32534    +26106     
- Partials        293      294        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SQLTODAG(string) -> DAG {name, sql, producers[]}
@aceforeverd aceforeverd requested a review from lqy222 January 2, 2024 02:34
@aceforeverd aceforeverd merged commit b33ebe2 into 4paradigm:main Jan 8, 2024
@aceforeverd aceforeverd deleted the feat-sql-to-dag branch January 8, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-engine hybridse sql engine sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants