fix: adding a deleted index will fail if the index name is different from the previous name#3635
Merged
dl239 merged 3 commits into4paradigm:mainfrom Jan 15, 2024
Merged
Conversation
github-actions
bot
added
the
storage-engine
dl239
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3635 +/- ##
=============================================
- Coverage 74.97% 40.16% -34.82%
Complexity 640 640
=============================================
Files 724 191 -533
Lines 130359 11233 -119126
Branches 1318 1325 +7
=============================================
- Hits 97742 4512 -93230
+ Misses 32324 6428 -25896
Partials 293 293 ☔ View full report in Codecov by Sentry. |
dl239
requested review from
aceforeverd,
lqy222,
tobegit3hub and
vagetablechicken
lqy222
approved these changes
Dec 21, 2023
aceforeverd
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?