Skip to content

Comments

fix: taskmanager ha reconnect#3668

Merged
vagetablechicken merged 2 commits into4paradigm:mainfrom
vagetablechicken:i3620
Jan 8, 2024
Merged

fix: taskmanager ha reconnect#3668
vagetablechicken merged 2 commits into4paradigm:mainfrom
vagetablechicken:i3620

Conversation

@vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Dec 7, 2023

closes #3620

After fix, tm can close and connect again when zk connection broken. And after reconnect, tm should try to become master. So add a thread for connection and master check.

@github-actions github-actions bot added the task-manager openmldb taskmanager label Dec 7, 2023
@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 256 lines in your changes are missing coverage. Please review.

Comparison is base (a8c0226) 40.16% compared to head (8dc2dc1) 74.89%.
Report is 1 commits behind head on main.

Files Patch % Lines
...adigm/openmldb/taskmanager/zk/FailoverWatcher.java 0.00% 140 Missing ⚠️
...aradigm/openmldb/taskmanager/zk/ZooKeeperUtil.java 0.00% 65 Missing ⚠️
.../openmldb/taskmanager/zk/RecoverableZooKeeper.java 0.00% 48 Missing ⚠️
...openmldb/taskmanager/server/TaskManagerServer.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3668       +/-   ##
=============================================
+ Coverage     40.16%   74.89%   +34.72%     
- Complexity      640      642        +2     
=============================================
  Files           191      725      +534     
  Lines         11233   130849   +119616     
  Branches       1325     1334        +9     
=============================================
+ Hits           4512    98000    +93488     
- Misses         6428    32556    +26128     
  Partials        293      293               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken vagetablechicken merged commit ebabc22 into 4paradigm:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task-manager openmldb taskmanager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Taskmanager will fail when restarting ZooKeeper

3 participants