fix: taskmanager ha reconnect#3668
Merged
vagetablechicken merged 2 commits into4paradigm:mainfrom Jan 8, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3668 +/- ##
=============================================
+ Coverage 40.16% 74.89% +34.72%
- Complexity 640 642 +2
=============================================
Files 191 725 +534
Lines 11233 130849 +119616
Branches 1325 1334 +9
=============================================
+ Hits 4512 98000 +93488
- Misses 6428 32556 +26128
Partials 293 293 ☔ View full report in Codecov by Sentry. |
aceforeverd
approved these changes
Dec 14, 2023
lqy222
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3620
After fix, tm can close and connect again when zk connection broken. And after reconnect, tm should try to become master. So add a thread for connection and master check.