Skip to content

Comments

feat: put if absent & insert or ignore#3692

Merged
vagetablechicken merged 13 commits into4paradigm:mainfrom
vagetablechicken:put-if-absent-pr
Jan 20, 2024
Merged

feat: put if absent & insert or ignore#3692
vagetablechicken merged 13 commits into4paradigm:mainfrom
vagetablechicken:put-if-absent-pr

Conversation

@vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Jan 5, 2024

  • insert or ignore in c++/java
  • put if absent for load data
  • abort imediately in spark data writer
  • appendentries fix: delete or put
  • doc
  • refactor spark connector config setup

@github-actions github-actions bot added documentation Improvements or additions to documentation docker openmldb compile image or demo image batch-engine openmldb batch(offline) engine sdk openmldb java/python sdk execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jan 5, 2024
@codecov
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (a112872) 78.27% compared to head (2694717) 74.89%.
Report is 8 commits behind head on main.

Files Patch % Lines
.../com/_4paradigm/openmldb/spark/OpenmldbConfig.java 0.00% 28 Missing ⚠️
.../com/_4paradigm/openmldb/spark/OpenmldbSource.java 0.00% 12 Missing ⚠️
...openmldb/spark/write/OpenmldbDataSingleWriter.java 0.00% 10 Missing ⚠️
src/sdk/sql_cluster_router.cc 55.00% 9 Missing ⚠️
src/storage/mem_table.cc 43.75% 9 Missing ⚠️
...adigm/openmldb/spark/write/OpenmldbDataWriter.java 0.00% 8 Missing ⚠️
...a/com/_4paradigm/openmldb/spark/OpenmldbTable.java 0.00% 6 Missing ⚠️
src/tablet/tablet_impl.cc 50.00% 6 Missing ⚠️
src/storage/disk_table.cc 42.85% 4 Missing ⚠️
src/storage/segment.cc 90.69% 4 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3692      +/-   ##
============================================
- Coverage     78.27%   74.89%   -3.39%     
- Complexity        0      655     +655     
============================================
  Files           553      728     +175     
  Lines        120481   131228   +10747     
  Branches          0     1366    +1366     
============================================
+ Hits          94312    98283    +3971     
- Misses        26153    32646    +6493     
- Partials         16      299     +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken vagetablechicken merged commit ff7e8ac into 4paradigm:main Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

batch-engine openmldb batch(offline) engine docker openmldb compile image or demo image documentation Improvements or additions to documentation execute-engine hybridse sql engine sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants