Skip to content

Comments

feat: update the schema of user table#3745

Merged
dl239 merged 2 commits into4paradigm:mainfrom
dl239:feat/update_user_table
Feb 22, 2024
Merged

feat: update the schema of user table#3745
dl239 merged 2 commits into4paradigm:mainfrom
dl239:feat/update_user_table

Conversation

@dl239
Copy link
Collaborator

@dl239 dl239 commented Feb 4, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Feb 4, 2024
@dl239 dl239 changed the title feat: update user table feat: update the schema of user table Feb 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2024

SDK Test Report

101 files  ±0  101 suites  ±0   2m 11s ⏱️ +4s
344 tests ±0  330 ✅ ±0  14 💤 ±0  0 ❌ ±0 
469 runs  ±0  455 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit 73de1d9. ± Comparison against base commit b8318b8.

This pull request removes 52 and adds 31 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.openmldb.batch.utils.DataSourceUtilTest ‑ Test AutoLoad Csv
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
com._4paradigm.openmldb.batch.utils.HybridseUtilTest ‑ Test read from hive
com._4paradigm.openmldb.batch.utils.DataSourceUtilTest ‑ Test read from hive

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b8318b8) 40.09% compared to head (73de1d9) 74.90%.
Report is 10 commits behind head on main.

Files Patch % Lines
src/sdk/sql_cluster_router.cc 86.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3745       +/-   ##
=============================================
+ Coverage     40.09%   74.90%   +34.81%     
  Complexity      657      657               
=============================================
  Files           193      736      +543     
  Lines         11414   132083   +120669     
  Branches       1374     1378        +4     
=============================================
+ Hits           4576    98938    +94362     
- Misses         6535    32842    +26307     
  Partials        303      303               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Linux Test Report

    57 files  ±0     244 suites  ±0   1h 15m 22s ⏱️ -35s
12 578 tests +1  12 571 ✅ +1  7 💤 ±0  0 ❌ ±0 
17 835 runs  +1  17 828 ✅ +1  7 💤 ±0  0 ❌ ±0 

Results for commit 73de1d9. ± Comparison against base commit b8318b8.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 2969018 into 4paradigm:main Feb 22, 2024
@dl239 dl239 deleted the feat/update_user_table branch February 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-engine openmldb storage engine. nameserver & tablet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants