Merged
Conversation
added 5 commits
March 19, 2024 12:01
1. mock `show character set` 2. mock `show collation` 3. mock `show engines` 4. mock multi query 5. mock `information_schema.ROUTINES` 6. define `please enter database first` error 7. mock select tables, select columns, select count union, create database query 8. fix IOException cause bug 9. mock `SHOW FULL TABLES WHERE Table_type != 'VIEW'`
1. fix mysql COM_INIT_DB bug 2. mock `show status` 3. mock `INFORMATION_SCHEMA.VIEWS` 4. skip table_id field of query `show table status` 5. sqlEngine support use database
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3816 +/- ##
=========================================
Coverage 40.70% 40.70%
Complexity 658 658
=========================================
Files 195 195
Lines 11514 11514
Branches 1380 1380
=========================================
Hits 4687 4687
Misses 6523 6523
Partials 304 304 ☔ View full report in Codecov by Sentry. |
Contributor
SDK Test Report101 files ±0 101 suites ±0 2m 11s ⏱️ +4s Results for commit 1cbaefd. ± Comparison against base commit 73c5844. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
Linux Test Report 53 files 60 suites 28m 4s ⏱️ For more details on these failures, see this check. Results for commit 1cbaefd. ♻️ This comment has been updated with latest results. |
Collaborator
|
pls rebase after #3814 |
# Conflicts: # extensions/open-mysql-db/README.md # extensions/open-mysql-db/src/main/java/com/_4paradigm/openmldb/mysql/server/ServerConfig.java
Collaborator
Author
DONE |
aceforeverd
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)