Conversation
added 12 commits
May 20, 2019 08:42
…ough we are not really modifying the topology so that if 'time' is used with 'crdaction' the warning about COORDS data sets not storing time values is printed.
Contributor
Author
|
It's not clear to me from the logs why the parallel Jenkins build failed. Going to try and retrigger. |
Contributor
Author
|
run jenkins |
Contributor
Author
|
Figured it out - needed to protect the test in parallel; NetCDF writes in parallel require parallel NetCDF which none of the MPI test rigs currently have. I wonder if I should consider bundling parallel NetCDF with cpptraj. |
Contributor
Author
|
Appveyor is still queued, but since Travis, Jenkins, and LGTM are happy I'm going to go ahead and merge now. |
Contributor
You can always add it to the Dockerfile. Then the Jenkins builds will have it, regardless of which slave it runs on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
timeaction for modifying time information in frames.Also adds tests for each of these modes and updates the manual.