Speed up six-dimensional entropy calculation in GIST#938
Merged
drroe merged 2 commits intoAmber-MD:masterfrom Jan 31, 2022
Merged
Speed up six-dimensional entropy calculation in GIST#938drroe merged 2 commits intoAmber-MD:masterfrom
drroe merged 2 commits intoAmber-MD:masterfrom
Conversation
In GIST, the six-dimensional entropy calculation requires the translational and orientational distance to the nearest neighbor (NN). However, if the translational distance is larger than the 6D distance to the current NN, the orientational distance can be skipped safely. This is a significant speedup (about 2x in my test), since the orientational distance contains an arccos.
Contributor
|
Sorry for the delay, didn't realize workflows needs my approval for first time contributors, that's new to me. I just sent the tests through. |
Contributor
|
@fwaibl Just one small thing, could you please increment the revision field in #define CPPTRAJ_INTERNAL_VERSION "V6.2.2"Thanks again, this is great! |
Contributor
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GIST, the six-dimensional entropy calculation requires the translational and orientational distance to the nearest neighbor (NN). However, if the translational distance is larger than the 6D distance to the current NN, the orientational distance can be skipped safely. This is a significant speedup (about 2x in my test), since the orientational distance contains an arccos.
I benchmarked using 10000 frames from a simulation of water around benzene (2700 water molecules). The box size was 80x80x80, with 0.5A spacing. I get the same entropy results, and the time in "Action Post" (from the cpptraj output) reduces from 545 to 263 seconds. I used the OMP version of cpptraj (with CUDA for the energy, but that shouldn't matter).