Merged
Conversation
Has no functional impact, just for clarity.
akirk
requested changes
Nov 23, 2022
Member
akirk
left a comment
akirk
left a comment
There was a problem hiding this comment.
Could you add a padding-bottom to avoid the cut-off handle?
Member
Author
|
The cut-off handle is due to b3bba5f, which I'm now convinced was not the correct fix for the problem, as it creates other problems. I have some ideas on how to fix the rounded corners problem in another way, which I'm exploring now. Adding padding fixes the cut-off handle but also adds padding, so I'd rather find a solution that addresses the root problem, which is b3bba5f. |
psrpinto
force-pushed
the
configure-height
branch
from
05193a4 to
f757010
Compare
psrpinto
force-pushed
the
configure-height
branch
from
8f0aa3b to
ea6179b
Compare
psrpinto
force-pushed
the
configure-height
branch
from
ea6179b to
0a4997a
Compare
Member
Author
akirk
approved these changes
Nov 23, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121
Screen recording
Screen.Recording.2022-11-23.at.16.30.00.mov
Next steps