Allow multiple Chatrix blocks on the same page or on different browser tabs#214
Merged
Allow multiple Chatrix blocks on the same page or on different browser tabs#214
Conversation
akirk
changed the title
This brakes the iframe build as the manifest gets picked up, somehow.
psrpinto
force-pushed
the
same-session-in-multiple-tabs
branch
2 times, most recently
from
4252003 to
3402210
Compare
ashfame
approved these changes
Apr 14, 2023
Member
ashfame
left a comment
ashfame
left a comment
There was a problem hiding this comment.
Looks good 👍
I am unclear on how to enable the feature flag though. I imagine, we would enable the feature flag for chatrix build and we would have it functional without making any changes in the settings. What am I missing?
ashfame
reviewed
Apr 14, 2023
Member
Author
The idea was that, for now, the user needs to go into Hydrogen's settings and enable the feature flag, since some things are broken, for example logout, and encrypted rooms, etc. Once we've address (some of?) these issues we can issue a new release with the feature flag enabled by default. Does that make sense? |
This was referenced Apr 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the changes from hydrogen related to "same session in multiple tabs" feature. The feature flag needs to be manually enabled through Settings, for now.
Enable feature flag
Open the same session in multiple tabsfeature flag