Generate a beancount file with transaction history for a descriptor#58
Merged
ChristopherA merged 24 commits intoBlockchainCommons:masterfrom May 3, 2022
Merged
Generate a beancount file with transaction history for a descriptor#58ChristopherA merged 24 commits intoBlockchainCommons:masterfrom
ChristopherA merged 24 commits intoBlockchainCommons:masterfrom
Conversation
Add `/exchanges` endpoint that returns exchange metadata. (Fixes BlockchainCommons#54) Cleanup variable and function naming style (https://google.github.io/styleguide/pyguide.html#316-naming) to fix BlockchainCommons#51. Freeze dependencies. Cleanup imports. Cleanup logging. Improve error handling. Refactor configuration settings. Load settings using dotenv. Use `flask run` to run the server. Begin refactor to simplify data collection. Use concurrent requests to servers. Remove unused functions. Remove database storage.
Use threads for HTTP requests.
Fix getting candles at specific dates.
…ative amount of btc.
nochiel
changed the title
Propagate a useful error to the command line. Raise an error from get_candles_at_dates if ccxt doesn't return any data for a request.
Contributor
Author
|
@icculp If you have time, here's another PR that could benefit from your review. 😄 |
Contributor
|
@nochiel Ready for merge? |
nochiel
changed the title
Contributor
Author
Yes, it is. Thanks. 👍🏾 |
ChristopherA
approved these changes
May 3, 2022
Contributor
ChristopherA
left a comment
ChristopherA
left a comment
There was a problem hiding this comment.
This PR was reviewed by an external volunteer, @hanhungsoo. As this project is still technically still "Late Alpha" and the current online version is unstable, I am going ahead and committing this PR to the master branch without additional review.
@shannona — we should tag this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #55.
Given an output descriptor, we would like to:
TODO (In subsequent PRs after this is merged)
Blockchain Commons and @ChristopherA should confirm what additional accounting data should be in the beancount file.
Tests for each descriptor type. Ensure that Spotbit can generate valid addresses supported by BDK.
UI: Add beancount UX to web front-end.
Package spotbit as an executable.
Example:
python app.py beancount "wpkh(tpubD9hudZxy8Uj3453QrsEbr8KiyXTYC5ExHjJ5sNDVW7yKJ8wc7acKQcpdbvZX6dFerHK6MfVvs78VvGfotjN28yC4ij6nr4uSVhX2qorUV8V/0/*)"Outputs:
spotbit.beancountReferences