This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Fix breadcrumbs in doc search modal#1123
Merged
anastasiya1155 merged 1 commit intomainfrom Nov 9, 2023
Merged
Conversation
ggordonhall
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the breadcrumbs when searching for a doc section can overflow its container and make it hard to read. Fix: enclose breadcrumbs in a container with overflow: hidden so that breadcrumbs can correctly calculate how many sections can fit. The space is still a bit limited but hiding middle sections should improve the UX