This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Automatically open bloop app after authentication with GitHub#1146
Merged
anastasiya1155 merged 2 commits intomainfrom Nov 22, 2023
Merged
Conversation
…authentication with GitHub
rsdy
approved these changes
Nov 20, 2023
Contributor
rsdy
left a comment
rsdy
left a comment
There was a problem hiding this comment.
To be honest, I don't perfectly understand how this will work, but the PR looks coherent.
stunningpixels
approved these changes
Nov 21, 2023
ggordonhall
approved these changes
Nov 22, 2023
anastasiya1155
deleted the
anastasiia/blo-1608-automatically-open-bloop-after-authentication
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve the user experience when signing in with GitHub we now will re-open and focus bloop app once the user is authenticated on the FE. Tried using a couple of JS APIs from Tauri - all working unreliably or not working at all. The only solution that seems to work is focusing the window from the Rust side. For it to work there is now a new Tauri command that can be invoked from the FE when onboarding is closed.