Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

  1. Add an stdin mode for the exec-harness, which allows running multiple commands. Commands are passed as JSON through stdin when invoking exec harness with exec-harness -
  2. Fix behavior of exec harness in walltime when executing different benchmarks
  3. Parse targets from codspeed.yaml when running codspeed run without arguments, and pass them to the exec-harness

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 18, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-1906-define-exec-targets-in-codspeedyaml (d37f7a6) with main (8d37e99)

Open in CodSpeed

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1906-define-exec-targets-in-codspeedyaml branch from 08878c1 to 9f6c8f9 Compare January 19, 2026 08:56
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1906-define-exec-targets-in-codspeedyaml branch from 9f6c8f9 to 85c9d5b Compare January 19, 2026 15:23
There was some imprecision with the different markers that were not
visible before, but now we have support to run multiple markers, we
handle warmup runs better.

Now, for each benchmark that is ran
1. We start perf monitorning and send SampleStart marker
2. We perform warmup rounds without sending BenchmarkStart and
   BenchmarkEnd markers
3. If we're in the "long warmup single run" edge case, we retroactively
   send the BenchmarkStart and BenchmarkStop markers
4. Else, we perform the measured rounds while sending the markers

This fixes flamegraph generation.
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1906-define-exec-targets-in-codspeedyaml branch from 85c9d5b to d37f7a6 Compare January 19, 2026 17:50
@GuillaumeLagrange GuillaumeLagrange merged commit d37f7a6 into main Jan 19, 2026
13 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1906-define-exec-targets-in-codspeedyaml branch January 19, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants