Fixed PackageId being overridden by MSBuild.Sdk.Extras import#171
Merged
Arlodotexe merged 2 commits intomainfrom Feb 29, 2024
Merged
Fixed PackageId being overridden by MSBuild.Sdk.Extras import#171Arlodotexe merged 2 commits intomainfrom
Arlodotexe merged 2 commits intomainfrom
Conversation
Arlodotexe
added
bug 🐛
michael-hawker
approved these changes
Feb 29, 2024
delete-merged-branch
bot
deleted the
fix/PackageId-overridden-by-msbuildextras
branch
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in c7ae0a0 that caused the wrong PackageId to be produced for some packages.
Importing MSBuild.Sdk.Extras in the place we did caused PackageId to be defined with a default. Our tooling doesn't reassign PackageId when there's an existing value, so the value defined by MsBuild/Extras was being used instead.
Before
After
