Merged
Conversation
michael-hawker
requested changes
Sep 6, 2023
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Few comments.
We should also pull over the PR template too as we'll want to have the warning about main forks in there as well as things like ensuring an issue is opened for the change (unless minor typo updates to typos/docs/docstrings...)
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Looking good! Couple of notes on PR template.
michael-hawker
approved these changes
Sep 7, 2023
Member
|
Awesome, we'll merge this once the release bits get settled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR