Fixed compositor nullreference in WinUI 3#299
Merged
michael-hawker merged 1 commit intomainfrom Dec 14, 2023
Merged
Conversation
24 tasks
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #235, #233
PR Summary
Introduces a hotfix for a regression in the WinUI 3 package where usage of the compositor in the PipelineBuilder resulted in a
NullReferenceException, caused by usage ofWindow.Current.Compositorinstead of the WinUI 3 equivalent.Still unable to launch the Wasdk sample app head for both the single-component Media solution and the gallery due to #212 and #169. These changes were tested by producing NuGet packages and testing in a blank Wasdk app.
PR Checklist
Please check if your PR fulfills the following requirements: