Merged
Conversation
Member
Author
|
The CI is passing for the submodule, but when building the Wasm head locally, I'm getting errors such as I've opened this PR early so we can see the errors in CI and iterate on this. |
Contributor
|
@Arlodotexe I think this may fix all the issues, will try to get it merged asap unoplatform/uno#14985 |
Arlodotexe
force-pushed
the
upgrade/uno5.0
branch
from
9e81a51 to
cc0857d
Compare
Contributor
|
@Arlodotexe ok, so still more to do 😞, I will try again tomorrow! |
Contributor
|
So one more fix coming in soon unoplatform/uno#15096 then we should be good hopefully |
Member
Author
|
@MartinZikmund Looks like Wasm produced an error in |
Arlodotexe
force-pushed
the
upgrade/uno5.0
branch
from
a4ac6da to
1f419d0
Compare
Member
Author
|
Found an issue after the Uno 5.0 update where the 'Overview' header is misplaced on WebAssembly:
This isn't the case on UWP: Or on Wasdk: Otherwise, no new issues with the components themselves. |
michael-hawker
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the submodule with CommunityToolkit/Tooling-Windows-Submodule#157
Closes #281.