Enhance: Add spacing properties for DockPanel

[Poker-sang]

Fixes

#293

PR Type

What kind of change does this PR introduce?

Enhance: Add spacing properties for DockPanel

HorizontalSpacing and VerticalSpacing

What is the current behavior?

No HorizontalSpacing and VerticalSpacing property

What is the new behavior?

Has HorizontalSpacing and VerticalSpacing property

PR Checklist

Please check if your PR fulfills the following requirements:

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• Tested code with current supported SDKs
• New component
  • Documentation has been added
  • Sample in sample app has been added
  • Analyzers are passing for documentation and samples
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (if applicable)
• Header has been added to all new source files
• Contains NO breaking changes

Other information

HorizontalSpacing="5" VerticalSpacing="5"

[michael-hawker]

Thanks @Poker-sang, great idea! Think the naming of these makes sense, aligns with our existing WrapPanel ones.

Not sure why the linux build is tripping up on the condensed syntax. Believe @Arlodotexe has updated and fixed the Uno-check conflict, but think that's in the #328 PR, so we may need to wait for that one to be merged (should be soon).

[Arlodotexe]

Noting the error message in the WinUI2 CI build for 78f0dd7:

2024-03-01T03:03:57.0643508Z        "C:\a\Windows\Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
2024-03-01T03:03:57.0644112Z        "C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj" (default target) (25:43) ->
2024-03-01T03:03:57.0644668Z        "C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj" (Build target) (25:49) ->
2024-03-01T03:03:57.0644807Z        (CoreCompile target) -> 
2024-03-01T03:03:57.0646318Z          C:\a\Windows\Windows\components\Primitives\src\DockPanel\DockPanel.cs(85,34): error CS0518: Predefined type 'System.Index' is not defined or imported [C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj::TargetFramework=uap10.0.17763]
2024-03-01T03:03:57.0647687Z          C:\a\Windows\Windows\components\Primitives\src\DockPanel\DockPanel.cs(85,34): error CS0656: Missing compiler required member 'System.Index..ctor' [C:\a\Windows\Windows\components\Primitives\src\CommunityToolkit.WinUI.Controls.Primitives.csproj::TargetFramework=uap10.0.17763]
2024-03-01T03:03:57.0647704Z 
2024-03-01T03:03:57.0647785Z     7 Warning(s)
2024-03-01T03:03:57.0647870Z     2 Error(s)
2024-03-01T03:03:57.0647875Z 
2024-03-01T03:03:57.0647990Z Time Elapsed 01:16:21.06
2024-03-01T03:03:57.0652749Z ##[error]Process completed with exit code 1.

[Poker-sang]

Noting the error message in the WinUI2 CI build for 78f0dd7:

Thanks for the heads up, I hadn't noticed it.

[Arlodotexe]

Locally tested, looks good! Added the new properties to the sample as well 👍