fix:On the Windows app SDK using CameraHelper, FrameArrived time execution for a period of time will not be triggered.#376
Merged
Arlodotexe merged 2 commits intoCommunityToolkit:mainfrom Mar 28, 2024
Conversation
…ution for a period of time will not be triggered.
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Thanks @GreenShadeZhang for digging into this issue and submitting a PR. 🦙❤️
update frame dispose Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Arlodotexe
approved these changes
Mar 28, 2024
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: On the Windows app SDK using CameraHelper, FrameArrived time execution for a period of time will not be triggered.
Maybe my modification is not perfect, but it seems that this can solve the problem of event triggering. I hope you can give some good opinions and suggestions so that this function can be used normally in Windows App SDK applications.
Fixes
Fixes #375
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, when a video frame arrives, the event is not triggered.
What is the new behavior?
Through my PR I test the video frame in the test code, and the video frame processing event is still triggered for a long time.
test-video.mp4
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
App11 is the test project I use.
App11.zip